Fix day picker for IE 11 (Also see Issue #668) #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS. can't silence eslint compelitly because of IE11 detection routine. :-( |
|
Thanks a lot @smesgr 🙏🏽Going to check it soon once I've prepared my Window virtual machine :) |
|
Just upgraded to latest 7.x release and seeing similar issue where you can't even pick a date in IE11. Ran the PR from @smesgr locally in an IE11 VM and it worked as expected.
|
gpbl
reviewed
Apr 17, 2018
| if (this.hideTimeout) { | ||
| this.hideTimeout = setTimeout(() => { | ||
| this.hideDayPicker(); | ||
| this.hideTimeout = null; |
There was a problem hiding this comment.
Wouldn't setting this.hideTimeout to null cause a memory leak here?
Merged
|
FWIW: until there's a new release fixing this, you can roll back to version |
|
Great Thanks |
|
I’m adding some more tests before releasing this. |
gpbl
added a commit
that referenced
this pull request
May 6, 2018
kimamula
pushed a commit
to kimamula/react-day-picker
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Day Picker IE 11 issue #668 for me.
Tested on the following browsers:
IE 11.0.56 @ Windows 10
Chrome/Chromium 65.0.3325.181 @ Windows 10, Ubuntu 18.04 LTS
Chrome 65.0.3325.109 @ Android 4.4
Edge 41.16299.248.0 @ Windows 10
Opera 52.0.2871.40 @ Windows 10
Firefox 59.0.2 @ Windows 10, Ubuntu 18.04 LTS
The proposed solution did not work for me. Therefore try to workaround this issue for IE by using setTimeout.