Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing v7.3.1 #916

Merged
merged 6 commits into from
Aug 8, 2019
Merged

Fix typing v7.3.1 #916

merged 6 commits into from
Aug 8, 2019

Conversation

gpbl
Copy link
Owner

@gpbl gpbl commented Aug 6, 2019

I'm trying to address #915.

@gpbl gpbl added help wanted Extra attention is needed src:TypeScript labels Aug 6, 2019
This was referenced Aug 6, 2019
Closed
Closed
@MKrupauskas
Copy link

External dependency parsimmon is using TS 2.3 features in its type definitions.

Error: Errors in typescript@2.2 for external dependencies:
../node_modules/@types/parsimmon/index.d.ts(417,41): error TS1005: ',' expected.
../node_modules/@types/parsimmon/index.d.ts(417,49): error TS1005: ',' expected.
../node_modules/@types/parsimmon/index.d.ts(417,49): error TS2300: Duplicate identifier 'T'.

    at /root/react-day-picker/node_modules/dtslint/bin/index.js:190:19
    at Generator.next (<anonymous>)
    at fulfilled (/root/react-day-picker/node_modules/dtslint/bin/index.js:5:58)
    at <anonymous>

replace all // TypeScript Version: 2.2 occurances to // TypeScript Version: 2.3.

Changing this resulted in another error

Desktop/react-day-picker-fix-typing-v7.3.1/types/DayPickerInput.d.ts:1:1
ERROR: 1:1  file-name-casing  Filename must be camelCase

but it's an easy fix.

MKrupauskas
MKrupauskas approved these changes Aug 8, 2019
View reviewed changes
Copy link

@MKrupauskas MKrupauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changed do fix the typescript errors.

@gpbl gpbl merged commit 2182c7c into master Aug 8, 2019
@gpbl
Copy link
Owner Author

gpbl commented Aug 8, 2019

Thanks @MKrupauskas for the help!

@Nibblesh Nibblesh mentioned this pull request Aug 14, 2019
Merged
@gpbl gpbl deleted the fix-typing-v7.3.1 branch October 21, 2019 12:50
kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
@gpbl
Fix typing v7.3.1 (gpbl#916)
c2977ae 
* Rename typings files

* Remove null

* Add typeof

* Rename files

* Update dtslint

* Update typescript version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKrupauskas MKrupauskas MKrupauskas approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpbl @MKrupauskas