Chore: Add ability to save state message from each gptscript call #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
force-pushed
the
add-state-record
branch
from
b4e865b to
52f990b
Compare
StrongMonkey
requested review from
thedadams,
njhale,
g-linville,
tylerslaton and
iwilltry42
tylerslaton
approved these changes
Mar 4, 2024
njhale
approved these changes
Mar 4, 2024
| @@ -115,6 +119,9 @@ func (r *Runner) call(callCtx engine.Context, monitor Monitor, env []string, inp | |||
| Type: EventTypeCallFinish, | |||
| Content: *result.Result, | |||
| }) | |||
| if err := recordStateMessage(result.State); err != nil { | |||
There was a problem hiding this comment.
nit: should a failure to write this debug info cause this method to error out? not sure if a warning log would be more appropriate.
There was a problem hiding this comment.
Good point. let's make sure this not fail and log a warning.
StrongMonkey
force-pushed
the
add-state-record
branch
from
52f990b to
228334d
Compare
Signed-off-by: Daishan Peng <daishan@acorn.io>
StrongMonkey
force-pushed
the
add-state-record
branch
from
228334d to
8fcf6d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save each gptscript api calls into Tmpdir with certain filename format.
This is used by @sanjay920 to analyze and train local LLM to be able to do function calling like gpt4 does.
Saving into tmpdir makes sure we don't pollute the user OS with too much files.
Developer is expected to upload these file to s3 in a timely fashion. Use
gptscript ./script/upload-s3.gptto upload to s3.