Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loud warnings to encourage nvidia-ml-py migration #55

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

rjzamora
Copy link
Collaborator

There are no plans to maintain the (unofficial) pynvml package. This PR is an attempt to encourage faster user migration to the official nvidia-ml-py package:

  • It adds a new warning to the top of the README file
  • It adds a FutureWarning when pynvml.smi is imported, since an equivalent module does not exist in nvidia-ml-py

@kenhester - I would prefer for the pynvml.smi warning to point the user somewhere else for smi support. Let me know if you (or anyone else) are motivated to create and maintain such space. Unfortunately, there is no change for that space to be within nvidia-ml-py.

@rjzamora rjzamora self-assigned this Jul 10, 2024
@rjzamora rjzamora marked this pull request as draft July 11, 2024 02:53
@rjzamora
Copy link
Collaborator Author

rjzamora commented Jul 11, 2024

Update...@pentschev pointed out in an offline discussion that it will be difficult for all RAPIDS-related projects to migrate to nvidia-ml-py in a coordinated way (which would be necessary since both packages are imported as pynvml). He suggested that we convert this repo to a "meta package" that simply adds nvidia-ml-py as a dependency. If we are taking the time to refactor the project in this way, it could also make sense to move the smi bindings into a distinct pynvml_utils module before the pynvml module is removed.

@rjzamora rjzamora marked this pull request as ready for review July 11, 2024 04:12
@rjzamora
Copy link
Collaborator Author

Merging the README change, and moving the smi refactor to a new PR.

@rjzamora rjzamora merged commit aeeea4f into gpuopenanalytics:master Jul 11, 2024
@rjzamora rjzamora deleted the loud-warnings branch July 11, 2024 04:13
@pentschev
Copy link

Thanks Rick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants