Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#fix: allocator for tristate_optional usage #583

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

#fix: allocator for tristate_optional usage #583

wants to merge 1 commit into from

Conversation

LiLatee
Copy link

@LiLatee LiLatee commented Feb 19, 2024 •
edited
Loading

Fix for the issue #582.

Explanation:

  • used allocators had always 0 imports, because allocate method was never called.

@knaeckeKami I am not familiar with the tests there. Could you explain how to fix them? 🙏

TODO:

  • fix test

@netlify Netlify
Copy link

netlify bot commented Feb 19, 2024 •
edited
Loading

✅ Deploy Preview for verdant-brigadeiros-5171fa canceled.

Name Link
🔨 Latest commit 322610c
🔍 Latest deploy log https://app.netlify.com/sites/verdant-brigadeiros-5171fa/deploys/65d36fb37dce160008686696

@LiLatee LiLatee mentioned this pull request Feb 19, 2024
Open
@knaeckeKami
Copy link
Collaborator

I am also not familar with these tests, but given the failure i highly suspect that the import prefix changed due to your changes

@LiLatee LiLatee marked this pull request as draft February 20, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiLatee @knaeckeKami