added team_reviewers

[adzienis]

Similar to #482, but we realized we would also like to add teams as reviewers as well.

[adzienis]

Combined reviewers and team_reviewers into one branch

[gr2m]

Can you update the action.yml?

[gr2m]

can you not force-push your commits? The PR can be messy, I'll squash & merge anyway. Just add more commits, it will make it easier to review the changes from my last review

[adzienis]

Removed team reviewer check in test.yml

[gr2m]

Thanks :) If you could give it a try once the new version is released, that'd be great

[github-actions]

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[adzienis]

Sure, thanks for the great feedback, and very quick responsiveness as well. apologies, but I'll be able to test it in a couple hours from now; i'll comment here with the status

[gr2m]

no rush :)

[adzienis]

well, the reviewers does seem to work. team_reviewers is being a bit tough rn. GH isn't showing any sort of teams I added to a private repo/org (as a scratch/test), even with two dummy users added to a team, so it's tougher to test that. No errors/exceptions thrown though when the team is listed in the workflow, just the team isn't assigned, but as of now, I can't manually assign/get them to show up anyway (even after fiddling with the normal settings to). possibly need time to sync? our team will most likely run this next action on Jan 2nd

[gr2m]

It's possible that the team_reviewers setting will not work if you set GITHUB_TOKEN to ${{ secrets.GITHUB_ACTION }}, because you might need the members:read permission for organization, which the token provided from GitHub Actions does not have. Try setting it to a personal access token with the repo and read:org scopes.

But you say that you yourself cannot assign a pull request reviewer to a team? The team needs read access to the repository

[adzienis]

Yeah, the team actually has admin privileges; which still doesn’t work strangely. I will try what you suggested with the token.