Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added team_reviewers #493

Merged
merged 5 commits into from
Dec 23, 2021
Merged

added team_reviewers #493

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a2982f
added team_reviewers
adzienis Dec 22, 2021
d376ab1
combined team_reviewers and reviewers in index.js
adzienis Dec 22, 2021
57e75b2
added better resiliency/null checks in combined logic; added
adzienis Dec 22, 2021
ebbe1b4
|| -> ?? in team_reviewers/reviewers
adzienis Dec 22, 2021
620b9fc
removed team reviewer check in test.yml
adzienis Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ jobs:
branch: test-add-reviewers-${{ github.run_number }}
commit-message: "Just testing [skip ci]"
reviewers: gr2m
team_reviewers: test-reviewers
- uses: octokit/request-action@v2.x
id: get-pull-request
with:
Expand All @@ -245,3 +246,5 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- if: ${{ !contains(toJson(fromJson(steps.get-pull-request.outputs.data).requested_reviewers.*.login), 'gr2m') }}
run: 'echo "Requested reviewers are \"${{ toJson(fromJson(steps.get-pull-request.outputs.data).requested_reviewers.*.login) }}\" but expected \"[\n gr2m \n]\"" && exit 1'
- if: ${{ !contains(toJson(fromJson(steps.get-pull-request.outputs.data).requested_teams.*.login), 'test-reviewers') }}
run: 'echo "Requested team reviewers are \"${{ toJson(fromJson(steps.get-pull-request.outputs.data).requested_teams.*.login) }}\" but expected \"[\n test-reviewers \n]\"" && exit 1'
adzienis marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ with:
labels: label1, label2
assignees: user1, user2
reviewers: user1, user2
team_reviewers: team1, team2
auto-merge: squash
update-pull-request-title-and-body: false
```
Expand Down
17 changes: 17 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ async function main() {
labels: core.getInput("labels"),
assignees: core.getInput("assignees"),
reviewers: core.getInput("reviewers"),
team_reviewers: core.getInput("team_reviewers"),
autoMerge: core.getInput("auto-merge"),
updatePRTitleAndBody: core.getInput("update-pull-request-title-and-body"),
};
Expand Down Expand Up @@ -239,6 +240,22 @@ async function main() {
core.debug(inspect(data));
}

if (inputs.team_reviewers) {
core.debug(`Adding team reviewers: ${inputs.team_reviewers}`);
const team_reviewers = inputs.team_reviewers.trim().split(/\s*,\s*/);
const { data } = await octokit.request(
`POST /repos/{owner}/{repo}/pulls/{pull_number}/requested_reviewers`,
{
owner,
repo,
pull_number: number,
team_reviewers
}
);
core.info(`Team reviewers added: ${team_reviewers.join(", ")}`);
core.debug(inspect(data));
}
adzienis marked this conversation as resolved.
Show resolved Hide resolved

if (inputs.autoMerge) {
const query = `
mutation($pullRequestId: ID!, $mergeMethod: PullRequestMergeMethod!, $commitHeadline: String!) {
Expand Down