Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for calling .{write,end}(buffer, callback) #17

Closed
gr2m opened this issue Dec 22, 2021 · 1 comment · Fixed by #21
Closed

Add test for calling .{write,end}(buffer, callback) #17

gr2m opened this issue Dec 22, 2021 · 1 comment · Fixed by #21
Labels

Comments

@gr2m
Copy link
Owner

gr2m commented Dec 22, 2021

Did you test when calling write, end et al. with a chunk and a callback

#3 (comment)

That's a minor thing, but given readable.setEncoding, the recorder is converting strings back to buffers presuming UTF-8(?).

My thinking here was to normalize the requestBodyChunks passed to the the record event listeners. I'm not worried about the performance overhead as this is a dev tool. Do you see any other problem? I will default encoding to utf-8 as part of #17

This was referenced Dec 22, 2021
@gr2m gr2m closed this as completed in #21 Dec 22, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant