feat: Add new checkout session endpoints + missing params #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbetta
requested review from
RonanFabricante and
steve-gr4vy
and removed request for
RonanFabricante
cbetta
commented
Aug 8, 2023
| @@ -39,7 +39,7 @@ public void getEmbedTokenTestWithCheckoutSessionPassedIn() throws Gr4vyException | |||
| embed.put("currency", "USD"); | |||
|
|
|||
| CheckoutSessionsApi checkoutSessionsApi = new CheckoutSessionsApi(client.getClient()); | |||
| CheckoutSession checkoutSession = checkoutSessionsApi.newCheckoutSession(); | |||
| CheckoutSession checkoutSession = checkoutSessionsApi.newCheckoutSession(new CheckoutSessionCreateRequest()); | |||
There was a problem hiding this comment.
[Info] This changes makes this technically a breaking change.
@steve-gr4vy what do you think of a major bump to 1.0.0?
There was a problem hiding this comment.
This is similar for the Go SDK which we haven't bumped previously (you can't have an optional parameter).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re TA-4928 updates API for use with new checkout session enhancements.
Also adds a few missing properties in latest OpenAPI updates.