feat: adds ip address to client, latest open api spec #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-gr4vy
reviewed
Aug 30, 2024
pom.xml
Outdated
| @@ -5,7 +5,7 @@ | |||
| <artifactId>gr4vy</artifactId> | |||
| <packaging>jar</packaging> | |||
| <name>gr4vy</name> | |||
| <version>0.29.2</version> | |||
| <version>0.3</version> | |||
There was a problem hiding this comment.
this should be 0.30.0
|
|
||
| GOPAY("gopay"), | ||
|
|
||
| GRABPAY("grabpay"), | ||
|
|
||
| IDEAL("ideal"), | ||
|
|
||
| ID("id"), |
There was a problem hiding this comment.
@phillipgr4vy did you manually add this? when I ran the generator earlier this was missing (so the openapi spec needs updating)?
There was a problem hiding this comment.
@steve-gr4vy the ID shouldnt of been added I've removed it. The googlepay_pan_only I manually added as this came up in the testing in spider. I can add this to openapi spec
There was a problem hiding this comment.
@phillipgr4vy The model files shouldn't be edited manually, they should be fully managed through the generation script - otherwise manual edits will be required each time the SDK models are updated. Can we update the openapi spec and re-run the generation script?
steve-gr4vy
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ip address to be set for new transactions via the X-Forwarded-For header and includes the latest open api spec models.