Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

48 refactor ci pipeline #49

Closed
wants to merge 37 commits into from
Closed

Conversation

victorggonzalez
Copy link
Contributor

This PR contains:

  • removed the unused test job inside the cdelivery-*.yml workflows. We now perform the integration test job in the Graasp Deploy workflow
  • cintegration-ecs-explorer.yml: include test job that matches the current cypress.yml workflow inside the library repo.
  • cintegration-s3-apps.yml: include test job that matches the current cypress.yml workflow inside apps repos. Add cache to build and deploy jobs to improve speed.
  • cintegration-s3.yml: include test job that matches the current cypress.yml workflow inside s3 repos. Add cache to build and deploy jobs to improve speed.
  • adapt all the *-caller.yml workflows to improve the changes made

@victorggonzalez victorggonzalez linked an issue Sep 6, 2022 that may be closed by this pull request
@victorggonzalez
Copy link
Contributor Author

Added cintegration-ecs-backend.yml to include test job that matches the current cypress.yml workflow inside the graasp repo. Add the appropriate secrets to the cintegration-ecs-backend-caller.yml

@victorggonzalez victorggonzalez marked this pull request as draft September 7, 2022 08:13
@victorggonzalez victorggonzalez marked this pull request as ready for review September 7, 2022 08:38
@victorggonzalez
Copy link
Contributor Author

Updated the build job for ecs-backend. Now the ecs-backend workflow has the following jobs:

  • build: install yarn dependencies and cache them for the test job, build image and cache it for the test job. Removed the build docker from this step and moved it to the deploy job. This is because build and test jobs will be executed every time we push a commit, so we avoid pushing images to ECR every time.
  • test: cache yarn dependencies and build image, and run yarn test
  • deploy: tag the image, build the docker image, push to the registry, fill task definition and deploy to dev.

@victorggonzalez victorggonzalez self-assigned this Sep 7, 2022
@victorggonzalez victorggonzalez marked this pull request as draft September 7, 2022 09:25
@victorggonzalez victorggonzalez marked this pull request as ready for review September 7, 2022 09:35
@victorggonzalez
Copy link
Contributor Author

victorggonzalez commented Sep 7, 2022

Updated the build job for ecs-explorer. Now the ecs-explorer workflow has the following jobs:

  • build: install yarn dependencies and cache them for the test job, build image and cache it for the test job. Removed the build docker from this job and moved it to the deploy job. This is because build and test jobs will be executed every time we push a commit, so we avoid pushing images to ECR every time.
  • test: cache yarn dependencies and build image, and run cypress test
  • deploy: tag the image, build the docker image, push to the registry, fill task definition and deploy to dev.

Copy link
Member

@juancarlosfarah juancarlosfarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some minor changes. Also, check to see if you can factor out the TASK DEFINITION and the NUMBER OF TASKS in a JSON for the ECS workflow.

.github/workflows/cdelivery-ecs-backend.yml Outdated Show resolved Hide resolved
.github/workflows/cintegration-ecs-backend.yml Outdated Show resolved Hide resolved
.github/workflows/cintegration-ecs-backend.yml Outdated Show resolved Hide resolved
.github/workflows/cintegration-ecs-explorer.yml Outdated Show resolved Hide resolved
@juancarlosfarah
Copy link
Member

@victorggonzalez @pyphilia, is this ready to merge?

@pyphilia
Copy link
Contributor

pyphilia commented Nov 4, 2022

I think this PR is too far behind the main branch to be applied. We should report the changes to a new branch.

I've already applied cache to workflows with a composite so this part is already done.

@pyphilia pyphilia closed this Feb 22, 2023
@spaenleh spaenleh deleted the 48-refactor-ci-pipeline branch December 11, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CI pipeline to remove unused test job
3 participants