feat: create document viewer component #976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pyphilia
approved these changes
Aug 8, 2024
| @@ -97,7 +98,7 @@ | |||
| "@emotion/cache": "~11.10.7 || ~11.11.0 || ~11.13.0", | |||
| "@emotion/react": "~11.10.6 || ~11.11.0 || ~11.13.0", | |||
| "@emotion/styled": "~11.10.6 || ~11.11.0 || ~11.13.0", | |||
| "@graasp/sdk": "^4.14.0", | |||
| "@graasp/sdk": "*", | |||
| @@ -116,7 +117,7 @@ | |||
| "@emotion/cache": "~11.11.0", | |||
| "@emotion/react": "11.11.4", | |||
| "@emotion/styled": "11.11.5", | |||
| "@graasp/sdk": "4.22.0", | |||
| "@graasp/sdk": "https://github.com/graasp/graasp-sdk.git#616-docs-mimetypes", | |||
| <FileDocument uri={url} /> | ||
| <DownloadButtonFileItem | ||
| id={id} | ||
| name={originalFileName ?? item.name} |
There was a problem hiding this comment.
I think we want to show the item.name
Suggested change
| name={originalFileName ?? item.name} | |
| name={item.name} |
| @@ -30,7 +30,7 @@ export const SizingWrapper = ({ | |||
| }): JSX.Element => { | |||
| const width = getWidthFromSizing(size); | |||
| return ( | |||
| <Box maxWidth='100%' width={width}> | |||
| <Box maxWidth='100%' width={width} flex={1}> | |||
There was a problem hiding this comment.
I would be careful here, why do you need flex=1? Add a comment, and could you please try out many different item types to be sure sizing is not broken?
| gap={0.5} | ||
| alignItems={alignItems} | ||
| width='100%' | ||
| flex={1} |
| import FileDocument from './FileDocument'; | ||
|
|
||
| const meta: Meta<typeof FileDocument> = { | ||
| title: 'Items/Document File', |
There was a problem hiding this comment.
I think Document is actually what it is, but because of our other nomenclature I would prefer something a bit closer to "viewer" and to the library you used.
Suggested change
| title: 'Items/Document File', | |
| title: 'Items/FileDocumentViewer', |
| type Props = { | ||
| uri: string; | ||
| }; | ||
| const FileDocument = ({ uri }: Props): JSX.Element => { |
There was a problem hiding this comment.
Suggested change
| const FileDocument = ({ uri }: Props): JSX.Element => { | |
| const FileDocumentViewer = ({ uri }: Props): JSX.Element => { |
pyphilia
reviewed
Aug 8, 2024
|
|
||
| export const Document: Story = { | ||
| args: { | ||
| uri: 'https://www.lehman.edu/faculty/john/classroomrespolicy1.docx', |
There was a problem hiding this comment.
I just read the docs, do you think we could use a local file like this:
{ uri: require("./example-files/pdf.pdf") }, // Local File
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #975