Skip to content

Commit

Permalink
Allow negative values in gr.Slider (#9988)
Browse files Browse the repository at this point in the history
* remove fallback values in slider

* story

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
  • Loading branch information
hannahblair and gradio-pr-bot authored Nov 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 2e2cdbf commit 2afcad8
Showing 3 changed files with 13 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .changeset/true-states-think.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@gradio/slider": patch
"gradio": patch
---

fix:Allow negative values in gr.Slider
6 changes: 3 additions & 3 deletions js/slider/Index.svelte
Original file line number Diff line number Diff line change
@@ -70,9 +70,9 @@
}
function set_slider_range(): void {
const range = range_input;
const min = Number(range.min) || 0;
const max = Number(range.max) || 100;
const val = Number(range.value) || 0;
const min = Number(range.min);
const max = Number(range.max);
const val = Number(range.value);
const percentage = ((val - min) / (max - min)) * 100;
range.style.setProperty("--range_progress", `${percentage}%`);
}
5 changes: 4 additions & 1 deletion js/slider/Slider.stories.svelte
Original file line number Diff line number Diff line change
@@ -25,8 +25,11 @@
/>

<Story
name="Slider with hidden label"
name="Slider with hidden label and negative value"
args={{
value: -50,
minimum: -100,
maximum: 0,
show_label: false
}}
/>

0 comments on commit 2afcad8

Please sign in to comment.