-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix reload mode by implementing
close
on the client (#8548)
* Fix reload mode * add changeset * reload test * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
- Loading branch information
1 parent
88de38e
commit 7fc0f51
Showing
3 changed files
with
89 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@gradio/client": patch | ||
"gradio": patch | ||
--- | ||
|
||
fix:Fix reload mode by implementing `close` on the client |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
import { test, expect } from "@playwright/test"; | ||
import { spawnSync } from "node:child_process"; | ||
import { launch_app_background, kill_process } from "./utils"; | ||
import { join } from "path"; | ||
|
||
let _process; | ||
|
||
const demo_file = "chat_demo.py"; | ||
|
||
test.beforeAll(() => { | ||
const demo = ` | ||
import gradio as gr | ||
def greet(msg, history): | ||
return "Hello" | ||
demo = gr.ChatInterface(fn=greet) | ||
if __name__ == "__main__": | ||
demo.launch() | ||
`; | ||
spawnSync(`echo '${demo}' > ${join(process.cwd(), demo_file)}`, { | ||
shell: true, | ||
stdio: "pipe", | ||
env: { | ||
...process.env, | ||
PYTHONUNBUFFERED: "true" | ||
} | ||
}); | ||
}); | ||
|
||
test.afterAll(() => { | ||
if (_process) kill_process(_process); | ||
spawnSync(`rm ${join(process.cwd(), demo_file)}`, { | ||
shell: true, | ||
stdio: "pipe", | ||
env: { | ||
...process.env, | ||
PYTHONUNBUFFERED: "true" | ||
} | ||
}); | ||
}); | ||
|
||
test("gradio dev mode correctly reloads a stateful ChatInterface demo", async ({ | ||
page | ||
}) => { | ||
test.setTimeout(20 * 1000); | ||
|
||
try { | ||
const port = 7890; | ||
const { _process: server_process } = await launch_app_background( | ||
`GRADIO_SERVER_PORT=${port} gradio ${join(process.cwd(), demo_file)}`, | ||
process.cwd() | ||
); | ||
_process = server_process; | ||
console.log("Connected to port", port); | ||
const demo = ` | ||
import gradio as gr | ||
def greet(msg, history): | ||
return "Hello" | ||
demo = gr.ChatInterface(fn=greet, textbox=gr.Textbox(label="foo")) | ||
if __name__ == "__main__": | ||
demo.launch() | ||
`; | ||
await page.goto(`http://localhost:${port}`); | ||
spawnSync(`echo '${demo}' > ${join(process.cwd(), demo_file)}`, { | ||
shell: true, | ||
stdio: "pipe", | ||
env: { | ||
...process.env, | ||
PYTHONUNBUFFERED: "true" | ||
} | ||
}); | ||
await expect(page.getByLabel("foo")).toBeVisible(); | ||
} finally { | ||
if (_process) kill_process(_process); | ||
} | ||
}); |