-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support audio uploads on iOS? #4021
Comments
Thanks for creating the issue @drscotthawley will look into it! |
Btw would you like to open a PR since it looks like you’ve already started with the solution? Otherwise we can do it on our end |
@abidlabs Re. the PR, I'd be happy to try but I'm not sure where in your code you're supplying that (MIME?) type information. I took a look at the Audio element in If one of your engineers could suggest a place to look, I could try again. |
Thanks @drscotthawley, what a coincidence! @aliabid94 on the Gradio team just opened a PR for this if you'd like to take a look: #4071 |
@abidlabs Oh yes!!! Thanks @aliabid94! |
Oh darn, I pulled the PR and put it in my app but got this message: ValueError: Did you install Gradio from source files? Share mode only works when Gradio is installed through the pip package. @abidlabs Do let me know when the pip package gets updated! :-) |
Related, FYI @abidlabs @aliabid94 : This Issue was about Uploading audio on iOS. What about Downloading audio on iOS?.... Answer: Turns out there appears to be no way to get the HTML5 Audio element controls on iOS to support a Download option. Period. Users who want to Download audio results will either have to stick to desktop browsers, or developers of Gradio demos who want to support audio downloads on iOS can either supply their own separate "Download Audio" button, or just post an HREF-style link for the output audio file (presumably by using the Just registering that information here in case anyone else asks. |
@drscotthawley do you know if we will be able to playback audio in ios? my users have been complaining about that, would like to see if I can contribute or be any help on that, and yes, for some reason gradio on mozilla firefox looks so nice including multiple functionalities like downloading the audio, in chrome is similar but you download the audio in a weird format that you can only reproduce using VLC |
@abidlabs also I dont mean to piggyback this but is there any way to speed up the audio? Ive been trying to do some code and research all options but for some reason gradio doesnt interpret all of the 6 strategies i used, I will keep looking around, and actually I provided the other day the documentation about being able to download audio from browsers, so im not only trying to extract value, will try to do my best to add and contribute more to the community, THANKS so much! |
@Alanp777 Not sure what you mean: I have no problem playing back in iOS. |
@Alanp777 no it doesnt work, try it yourself https://huggingface.co/spaces/WXM2000/audio_to_text_Chinese or any other space, try to playback the audio on Safari browser, also my users complain about the same |
@Alanp777 All my apps work fine. been doing it for weeks. on iOS.
And I just did tried link you sent and it worked fine: recorded myself played it back.
On my iPhone. Safari.
🤷
On May 7, 2023, at 4:24 PM, Alanp777 ***@***.***> wrote:
@Alanp777<https://github.com/Alanp777> no it doesnt work, try it yourself https://huggingface.co/spaces/WXM2000/audio_to_text_Chinese
or any other space, try to playback the audio on Safari browser, also my users complain about the same
—
Reply to this email directly, view it on GitHub<#4021 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADKH2NOTALOUOXXNDXJLDZTXFAHHXANCNFSM6AAAAAAXRNJ6Q4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@drscotthawley my apologies, I should have specified, Safari Browser on DESKTOP, not iOS, my mistake. |
@Alanp777 No, that works fine for me too. Just tried it. On my Mac. In Safari. ✅ Is perhaps your default audio device assigned incorrectly in System Preferences? |
Confirming that iOS audio uploads now work in PyPI |
Great, thanks for confirming @drscotthawley! |
Following up on this Discussion and request to add Issue by @abidlabs :
https://github.com/gradio-app/gradio/discussions/3998
iOS is a little funny and while the way Gradio configures Audio input elements should be ok, somehow it's not.
Pasting from the above-mentioned Discussion:
The text was updated successfully, but these errors were encountered: