Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gr.ImageEditor hides the editor icons on Gradio 5.x if height is too small #9694

Closed
1 task done
apolinario opened this issue Oct 14, 2024 · 5 comments · Fixed by #10037
Closed
1 task done

gr.ImageEditor hides the editor icons on Gradio 5.x if height is too small #9694

apolinario opened this issue Oct 14, 2024 · 5 comments · Fixed by #10037
Assignees
Labels
bug Something isn't working 🖼️ ImageEditor Priority High priority issues

Comments

@apolinario
Copy link
Contributor

apolinario commented Oct 14, 2024

Describe the bug

The tools to edit the image are hidden when a square or portrait image is uploaded, rendering the demo unusable (at least with 2 Gradio blocks columns)

image

Have you searched existing issues? 🔎

  • I have searched and found no existing issues

Reproduction

Here is a demo with repro: https://huggingface.co/spaces/ameerazam08/FLUX.1-dev-Inpainting-Model-Alpha-GPU

Screenshot

No response

Logs

No response

System Info

gradio==5.0.1

Severity

I can work around it

@apolinario apolinario added the bug Something isn't working label Oct 14, 2024
@abidlabs abidlabs added the Priority High priority issues label Oct 15, 2024
@danilwithonei
Copy link

just increase the height value of gr.ImageEditor

    inputs=gr.ImageEditor(
        height=1000, #<---
        brush=gr.Brush(
            default_size=10,
            default_color="#000000",
        ),
    ),

@apolinario
Copy link
Contributor Author

Great workaround, thanks! But probably better to have it resize based on the image size, so it doesn't occupy a huge height

@abidlabs abidlabs changed the title gr.ImageEditor hides the editors on Gradio 5.x gr.ImageEditor hides the editor icons on Gradio 5.x Oct 23, 2024
@abidlabs abidlabs changed the title gr.ImageEditor hides the editor icons on Gradio 5.x gr.ImageEditor hides the editor icons on Gradio 5.x if height is too small Oct 23, 2024
@FurkanGozukara
Copy link

this issue still exists i just got a complaint from a user :(

@hannahblair
Copy link
Collaborator

Hi @FurkanGozukara! I'll have a PR up for this asap. Sorry for the wait!

@FurkanGozukara
Copy link

Hi @FurkanGozukara! I'll have a PR up for this asap. Sorry for the wait!

awesome ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🖼️ ImageEditor Priority High priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants