Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure toolbar stays visible for large images in ImageEditor #10037

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Nov 25, 2024

Description

Large images were causing the toolbar from being pushed down outside the container, and check that the behaviour is consistent when changing the height of the container.

To test, upload super tall images and test crop. Note there are still some other known issues around ImageEditor which I'd prefer to fix in another PR. e.g:

  • Zoom is needed for large images because it becomes too small to edit easily
  • Cropping is behaving strangely when the crop ratio isn't 1:1 (see here)
  • Choosing webcam sources is buggy
  • Colour change selection not working

Please do mention anything else you notice that's not been flagged 🐛

Closes: #9694

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 25, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/9e4282d959a0f6c37f6a63fd4860a92895b9239a/gradio-5.6.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9e4282d959a0f6c37f6a63fd4860a92895b9239a#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/9e4282d959a0f6c37f6a63fd4860a92895b9239a/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/9e4282d959a0f6c37f6a63fd4860a92895b9239a/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 25, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/imageeditor patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Ensure toolbar stays visible for large images in ImageEditor

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @hannahblair ! For me, every image upload was causing the toolbar to disappear so this PR definitely fixes it!

I noticed that all images are now the same size in the image editor (see gif), is there a way to control that?

ie_uload

Also, I think the right issue to close is #9694

Otherwise, let's fix the lint and get this in!

@hannahblair
Copy link
Collaborator Author

thanks @freddyaboulton! I've actually increased the max height threshold which prevents any overflow still so your larger images should be scaled a bit more. The images aren't necessarily the same size but if they're greater than the max_height then they'll be capped at that the max_height.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks @hannahblair !!

@hannahblair hannahblair merged commit d0b74ba into main Nov 26, 2024
24 checks passed
@hannahblair hannahblair deleted the ie-toolbar-overflow branch November 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.ImageEditor hides the editor icons on Gradio 5.x if height is too small
3 participants