-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure toolbar stays visible for large images in ImageEditor #10037
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/9e4282d959a0f6c37f6a63fd4860a92895b9239a/gradio-5.6.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9e4282d959a0f6c37f6a63fd4860a92895b9239a#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/9e4282d959a0f6c37f6a63fd4860a92895b9239a/gradio-client-1.8.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/9e4282d959a0f6c37f6a63fd4860a92895b9239a/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @hannahblair ! For me, every image upload was causing the toolbar to disappear so this PR definitely fixes it!
I noticed that all images are now the same size in the image editor (see gif), is there a way to control that?
Also, I think the right issue to close is #9694
Otherwise, let's fix the lint and get this in!
…to ie-toolbar-overflow
thanks @freddyaboulton! I've actually increased the max height threshold which prevents any overflow still so your larger images should be scaled a bit more. The images aren't necessarily the same size but if they're greater than the max_height then they'll be capped at that the max_height. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks @hannahblair !!
Description
Large images were causing the toolbar from being pushed down outside the container, and check that the behaviour is consistent when changing the height of the container.
To test, upload super tall images and test crop. Note there are still some other known issues around ImageEditor which I'd prefer to fix in another PR. e.g:
Please do mention anything else you notice that's not been flagged 🐛
Closes: #9694
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh