Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building multipage Gradio apps #10433

Merged
merged 64 commits into from
Feb 5, 2025
Merged

Allow building multipage Gradio apps #10433

merged 64 commits into from
Feb 5, 2025

Conversation

aliabid94
Copy link
Collaborator

@aliabid94 aliabid94 commented Jan 24, 2025

Closes: #2654

Implemented multipage. This is the syntax:

import gradio as gr

with gr.Blocks() as demo:
    name = gr.Textbox(label="Name")
    ...

with demo.route("Test", "/test"):
    num = gr.Number()
    ....

demo.launch()

See demo/multipage/run.py below:

Recording 2025-01-24 at 08 04 25

Initially I had implemented separate routes as separate Blocks but then it got real messy with trying to unify the queue, Stateholder and other backend things across multiple Blocks, so now we just keep the configs separate for different pages but the Blocks is shared.

Did not yet implement shared state or components across pages, because it's still unclear what the intended behaviour should be, still need to discuss.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 24, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/1fb08530e719e073c9741898d6923c51d2b3f547/gradio-5.14.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@1fb08530e719e073c9741898d6923c51d2b3f547#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/1fb08530e719e073c9741898d6923c51d2b3f547/gradio-client-1.10.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/1fb08530e719e073c9741898d6923c51d2b3f547/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 24, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/client minor
@gradio/core minor
@gradio/lite minor
@self/app minor
@self/spa minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Allow building multipage Gradio apps

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs requested review from hysts and yvrjsharma January 24, 2025 18:03
@abidlabs
Copy link
Member

I get this error when trying demo/multipage/run.py or the toy example above:

TypeError: document..inner_doc() takes 1 positional argument but 2 were given

@aliabid94
Copy link
Collaborator Author

I get this error when trying demo/multipage/run.py or the toy example above:

Whoops fixed

@abidlabs
Copy link
Member

Thanks @aliabid94, the demo is working for me now in regular mode.

  • However, SSR mode demo.launch(ssr_mode=True) is not working for me, which means it doesn't work by default on Spaces. The content for both of the pages loads together and cliking on the "Up" has no effect:
image

Btw without SSR, multipage does feel a bit slow on Spaces: https://huggingface.co/spaces/abidlabs/multipage

  • For the navbar UI, I suggest moving the links to the right (to be more compatible with gr.Sidebar and to potentially leave space in the left for a navbar brand image), removing the bullets, and using background shading to indicate the currently selected page.

gradio/routes.py Outdated
@@ -592,6 +609,7 @@ def api_info(request: fastapi.Request):
@app.get("/config", dependencies=[Depends(login_check)])
def get_config(request: fastapi.Request):
config = utils.safe_deepcopy(app.get_blocks().config)
# del config["page"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to remove this comment?

@hannahblair
Copy link
Collaborator

For the navbar UI, I suggest moving the links to the right (to be more compatible with gr.Sidebar and to potentially leave space in the left for a navbar brand image), removing the bullets, and using background shading to indicate the currently selected page.

I'm not sure I agree about moving the links to the right but I do like the background shading idea! I do think we need the nav links to stand out a bit more. I can also experiment a little bit myself.

Ali Abid and others added 2 commits January 27, 2025 22:37
@aliabid94
Copy link
Collaborator Author

SSR mode (and dev mode) now work @abidlabs

@abidlabs
Copy link
Member

I do think we need the nav links to stand out a bit more.

I agree! In terms of a visual heirarchy, if a gradio app has both pages and tabs, the page links in the navbar should be more prominent but right now, they are less prominent than the tabs

@abidlabs
Copy link
Member

@abidlabs abidlabs changed the title Multipage Allow building multipage Gradio apps Feb 4, 2025
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was testing out the latest commit. The multipage demo works well (event tried sub-mounting it into a larger fastapi app and it worked). But I noticed that a vanilla interface demo (demo/calculator) will not render? Doesn't happen with Blocks or ChatInterface.

This is the error in the console

Uncaught (in promise) RangeError: Maximum call stack size exceeded
    at get_slot_context (svelte.js:169:26)
    at create_slot (svelte.js:164:20)
    at fe (Block.svelte:91:24)
    at _e (Block.svelte:60:11)
    at init (svelte.js:3283:34)
    at new ae (Block.svelte:40:10)
    at ue (Index.svelte:80:16)
    at init (svelte.js:3283:34)
    at new Se (Index.svelte:55:17)
    at Object.construct (RenderComponent.svelte:31:11)
2025-02-04_10-56-47.mp4

@aliabid94
Copy link
Collaborator Author

But I noticed that a vanilla interface demo (demo/calculator) will not render

Fixed!

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Noticed a couple of small issues. Also reload mode does not work with multiple pages (every link in the navbar will point to the same page).

gradio/blocks.py Show resolved Hide resolved
js/core/src/Embed.svelte Show resolved Hide resolved
guides/04_additional-features/09_multipage-apps.md Outdated Show resolved Hide resolved
@aliabid94
Copy link
Collaborator Author

Works great! Noticed a couple of small issues

I think I've fixed them all now!

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my tests locally and on Spaces. Great work @aliabid94!

@aliabid94 aliabid94 enabled auto-merge (squash) February 5, 2025 01:37
@aliabid94 aliabid94 disabled auto-merge February 5, 2025 03:08
@aliabid94 aliabid94 merged commit 2e8dc74 into main Feb 5, 2025
22 of 23 checks passed
@aliabid94 aliabid94 deleted the pages_2 branch February 5, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple pages in a gradio app
5 participants