Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrapper function of micropip.install to throw the original error for better debug experience #10466

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Jan 30, 2025

Description

Now installPackages() (introduced by #10366) hides the error thrown from micropip.install() and it makes debugging less easy.

CleanShot 2025-01-30 at 17 20 28@2x

This PR fixes it so the original error is properly shown:

CleanShot 2025-01-30 at 17 21 15@2x

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 30, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/aad5f41ab2eb0641576f962916aae1d127ebc4bf/gradio-5.15.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@aad5f41ab2eb0641576f962916aae1d127ebc4bf#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/aad5f41ab2eb0641576f962916aae1d127ebc4bf/gradio-client-1.11.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/aad5f41ab2eb0641576f962916aae1d127ebc4bf/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 30, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/lite patch
@gradio/wasm patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix the wrapper function of micropip.install to throw the original error for better debug experience

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx force-pushed the fix-install-retry-delegate-error branch from a3ca379 to f777a1a Compare January 30, 2025 08:19
@whitphx whitphx marked this pull request as ready for review February 6, 2025 05:42
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whitphx !

@freddyaboulton freddyaboulton added t: fix A change that implements a fix v: patch A change that requires a patch release labels Feb 6, 2025
@abidlabs
Copy link
Member

abidlabs commented Feb 7, 2025

Going to merge this in, thanks folks!

@abidlabs abidlabs merged commit 8e2cf2f into main Feb 7, 2025
24 checks passed
@abidlabs abidlabs deleted the fix-install-retry-delegate-error branch February 7, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants