Clean up gr.DataFrame.postprocess() and fix issue with getting headers of empty dataframes
#10476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/b17392159b0d8eace2a533e6333dce5e90ebaf27/gradio-5.14.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b17392159b0d8eace2a533e6333dce5e90ebaf27#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/b17392159b0d8eace2a533e6333dce5e90ebaf27/gradio-client-1.10.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/b17392159b0d8eace2a533e6333dce5e90ebaf27/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
requested review from
aliabid94,
dawoodkhan82,
hysts and
freddyaboulton
hysts
reviewed
Jan 31, 2025
freddyaboulton
approved these changes
Jan 31, 2025
| if len(value) > 0 and isinstance(value[0], list): | ||
| return len(value[0]) == 0 | ||
| return len(value) == 0 | ||
| elif isinstance(value, dict): |
There was a problem hiding this comment.
nit: I think the logic for dict is inconsistent. A df is empty if it has no values (even if his has headers). The dict is considered empty only if it doesn't have headers and values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10474, refactored the
.postprocess()method significantly to break it up into smaller methods & added tests for each method.