-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gr.Plot change/load events and plotly css loaded #10544
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/f5c96422df93a977364082741fbe3718231fae29/gradio-5.15.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f5c96422df93a977364082741fbe3718231fae29#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/f5c96422df93a977364082741fbe3718231fae29/gradio-client-1.11.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/f5c96422df93a977364082741fbe3718231fae29/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
gradio/components/plot.py
Outdated
@@ -39,7 +39,7 @@ class Plot(Component): | |||
""" | |||
|
|||
data_model = PlotData | |||
EVENTS = [Events.change, Events.clear] | |||
EVENTS = [Events.change, Events.clear, Events.load] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the rationale for adding the .load()
event to gr.Plot()
? Why are we adding .load()
to a component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got my wires crossed for a second - backed this out
b81eb70
to
a13adc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @freddyaboulton! As a side note, I noticed that the Plot
component has a .clear()
event, which is never actually called. We should probably just remove that event since there's no built-in clear button for the Plot component
Thanks @abidlabs ! |
Description
Closes: #10252
Closes: #9997
Can't repro #10252 but I have refactored the code to only load the plotly css once.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh