Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gr.Plot change/load events and plotly css loaded #10544

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

freddyaboulton
Copy link
Collaborator

Description

Closes: #10252
Closes: #9997

Can't repro #10252 but I have refactored the code to only load the plotly css once.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@freddyaboulton freddyaboulton added the v: patch A change that requires a patch release label Feb 7, 2025
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 7, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/f5c96422df93a977364082741fbe3718231fae29/gradio-5.15.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f5c96422df93a977364082741fbe3718231fae29#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/f5c96422df93a977364082741fbe3718231fae29/gradio-client-1.11.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/f5c96422df93a977364082741fbe3718231fae29/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 7, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/plot patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix gr.Plot change/load events and plotly css loaded

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton added the t: fix A change that implements a fix label Feb 7, 2025
@freddyaboulton freddyaboulton marked this pull request as ready for review February 7, 2025 20:21
@freddyaboulton freddyaboulton requested review from aliabid94, abidlabs, dawoodkhan82, pngwn and hannahblair and removed request for aliabid94 February 7, 2025 20:21
@@ -39,7 +39,7 @@ class Plot(Component):
"""

data_model = PlotData
EVENTS = [Events.change, Events.clear]
EVENTS = [Events.change, Events.clear, Events.load]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the rationale for adding the .load() event to gr.Plot()? Why are we adding .load() to a component?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got my wires crossed for a second - backed this out

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @freddyaboulton! As a side note, I noticed that the Plot component has a .clear() event, which is never actually called. We should probably just remove that event since there's no built-in clear button for the Plot component

@freddyaboulton freddyaboulton enabled auto-merge (squash) February 8, 2025 00:44
@freddyaboulton
Copy link
Collaborator Author

Thanks @abidlabs !

@freddyaboulton freddyaboulton merged commit 9b87e12 into main Feb 8, 2025
23 checks passed
@freddyaboulton freddyaboulton deleted the fix-plot-change-event branch February 8, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser get Out of Memory when using Plotly for plotting. gr.Plot not firing .change event
3 participants