Restrict proxy URLs #4406
Merged
Restrict proxy URLs #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4406-all-demos |
akx
reviewed
Jun 2, 2023
Co-authored-by: Aarni Koskela <akx@iki.fi>
Co-authored-by: Aarni Koskela <akx@iki.fi>
… into further-restrict-proxy
akx
reviewed
Jun 2, 2023
|
Suggestions should be addressed now @akx, please feel free to re-review! |
akx
reviewed
Jun 2, 2023
|
Tests have been updated -- @freddyaboulton @dawoodkhan82 or @aliabid94 would you be able to give this a review so that we can merge in? |
Hmm interesting, let me see what's happening there |
|
Ok let me merge this in and then I'll look at the file path issue in a separate PR. Thanks again for the reviews @akx and @freddyaboulton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricts proxy URLs to those that a user has loaded through
gr.load().Solves two issues:
(1) Prevents users from carrying out SSRF (using other people's Spaces to make requests through the /proxy route)
(2) Prevents harvesting of a Space's HF tokens
cc @akx