Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pypi classifiers to client pyproject.toml #4409

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

WilliamRoyNelson
Copy link
Contributor

@WilliamRoyNelson WilliamRoyNelson commented Jun 3, 2023

Description

Adds classifiers to gradio-client as a continuation of #4383
which added the following classifiers to the PyPI metadata for gradio:
image

The only difference with this is that it's for gradio-client, and the Scientific/Engineering :: Visualization tag has been replaced with Software Development :: User Interfaces

Previous change, #4383, was successful and can be seen at https://pypi.org/project/gradio/

No Changelog is necessary as it does not change the functionality of the library

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
    directly via drag-and-drop.

@gradio-pr-bot
Copy link
Collaborator

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4409-all-demos

@@ -19,6 +19,22 @@ authors = [
]
keywords = ["machine learning", "client", "API"]

classifiers = [
'Development Status :: 5 - Production/Stable',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nit here @WilliamRoyNelson is that we should probable use Development Status :: 4 - Beta as the client is still pre 1.0 version and some apis may change. Do you mind making the change?

Otherwise this looks good to me! Thanks again for the help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've made the requested change... and accidentally closed the PR while trying to rebase, but I think it's good and reopened now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamRoyNelson WilliamRoyNelson force-pushed the main branch 2 times, most recently from 55030c0 to e8f44a9 Compare June 5, 2023 19:56
@WilliamRoyNelson WilliamRoyNelson force-pushed the main branch 2 times, most recently from e8f44a9 to 3796761 Compare June 5, 2023 19:58
@abidlabs
Copy link
Member

abidlabs commented Jun 5, 2023

Will go ahead and merge this in, thanks again @WilliamRoyNelson and @freddyaboulton

@abidlabs abidlabs merged commit 20d066c into gradio-app:main Jun 5, 2023
@WilliamRoyNelson
Copy link
Contributor Author

@abidlabs @freddyaboulton
I was wondering if this could get pushed to PyPI to update the metadata.

Also, I've noticed that the version on PyPI is listed as 0.2.5, but the changelog is still at 0.2.4
Do you want me to put in a PR to move the documentation forward to reflect PyPI's current state?
WilliamRoyNelson@e41f8b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants