-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pypi classifiers to client pyproject.toml #4409
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4409-all-demos |
client/python/pyproject.toml
Outdated
@@ -19,6 +19,22 @@ authors = [ | |||
] | |||
keywords = ["machine learning", "client", "API"] | |||
|
|||
classifiers = [ | |||
'Development Status :: 5 - Production/Stable', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nit here @WilliamRoyNelson is that we should probable use Development Status :: 4 - Beta
as the client is still pre 1.0 version and some apis may change. Do you mind making the change?
Otherwise this looks good to me! Thanks again for the help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I've made the requested change... and accidentally closed the PR while trying to rebase, but I think it's good and reopened now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WilliamRoyNelson!
55030c0
to
e8f44a9
Compare
e8f44a9
to
3796761
Compare
Will go ahead and merge this in, thanks again @WilliamRoyNelson and @freddyaboulton |
@abidlabs @freddyaboulton Also, I've noticed that the version on PyPI is listed as 0.2.5, but the changelog is still at 0.2.4 |
Description
Adds classifiers to gradio-client as a continuation of #4383
which added the following classifiers to the PyPI metadata for gradio:
The only difference with this is that it's for gradio-client, and the Scientific/Engineering :: Visualization tag has been replaced with Software Development :: User Interfaces
Previous change, #4383, was successful and can be seen at https://pypi.org/project/gradio/
No Changelog is necessary as it does not change the functionality of the library
directly via drag-and-drop.