Fix bug where file examples can be corrupted if has multiple extensions #4440
Conversation
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4440-all-demos |
|
The changelog for gradio-client is currently a little off. I have a PR to fix it, but I want to make sure that your changes to the changelog don't result in a merge conflict. Before merging, would you please ensure that everything's in the right place? |
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_examples_keep_all_suffixes(tmp_path): |
There was a problem hiding this comment.
Need to release a new version of the client to get this test to pass
freddyaboulton
requested review from
abidlabs,
aliabid94,
aliabd,
dawoodkhan82,
pngwn and
hannahblair
|
LGTM @freddyaboulton thanks for this fix! Also fixes a long-standing problem with the name of cached example output files would be different than if you just re-ran the function. I'll start by releasing a version of the Python Client (0.2.6) off of this branch. Then, will confirm tests for the main library are passing before merging in this PR |
…radio-app/gradio into 4424-fix-filename-examples-two-periods
|
@WilliamRoyNelson I also moved the changelog entries to the right place, thanks for bringing that to our attention |
|
Everything looks good, thanks folks! |
|
Thanks for the review @abidlabs ! |
Description
Fixes #4424 by preserving the entire filename in the file cached for examples
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.