Support Pydantic V2 and patch release #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4835-all-demos |
|
Chromatic build successful 🎉 |
freddyaboulton
requested review from
pngwn,
aliabid94,
abidlabs,
aliabd,
dawoodkhan82 and
hannahblair
and removed request for
aliabid94
abidlabs
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
LGTM nice fix @freddyaboulton!
Tested with old (0.96) and latest (0.100) versions of fastapi and can confirm demos work properly in both.
|
Thanks for the review @abidlabs ! |
freddyaboulton
force-pushed
the
hotfix-pydantic
branch
from
0d298b1 to
23a34a2
Compare
|
Just FYI @freddyaboulton some of the flaky tests might be timing out |
1 task
|
Ah yeah it's because https://huggingface.co/spaces/freddyaboulton/calculator is broken. We should fix that manually and the version upgrade should take of everything else |
freddyaboulton
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fastapi 0.100.0 got released an hour ago and it supports pydantic v2 which introduces some changes that invalidate our models. This causes requests to fail with 422 error code. You can see that here: https://huggingface.co/spaces/gradio/calculator_main
I updated the models to match pydantic v2 using the migration guide and its backwards compatible change with pydantic v1.
I installed pydantic v1 on this branch locally and the demo still works:
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests & Changelog
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.shUnless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in
CHANGELOG.md:Please add a brief summary of the change to the Upcoming Release section of the
CHANGELOG.mdfile and includea link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".