-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve URL handling in JS Client #8258
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/f17855cf0d974ad4076ee8df3e8c3ce60eef0cee/gradio-4.31.5-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f17855cf0d974ad4076ee8df3e8c3ce60eef0cee#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…into root-url-client
…into root-url-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, otherwise looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks @hannahblair!
Nice! |
Thanks, Have been looking for this update. Getting this error, when trying to install it Is this the right way to install it
|
Hi @autherous!
|
It could also just be that poetry doesn't like this way of installing packages. It does differ from pop in certain ways. |
Description
This PR ensures that we correctly handle URLs in various formats. E.g. We weren't handling URLs with paths (to an extent) or URLs with trailing slashes. This also resulted in issues around fetching
theme.css
,/config
and/info
in some cases.The following should now work (providing a gradio space is to be found at these URLs):
To test, run this python app and mount the gradio app on various paths:
then in a separate app (or in serve an app as a static file with fastAPI), test you can connect to the app.
You can also test that it fixes #4463 by testing embedding with the custom path:
Closes: #4469
Closes: #4463
Closes: #3472
Closes: #8154
Closes: #8199
Closes: #8073
(probably) Closes: #8129
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh