-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an optional height
and overflow scrollbar for the Markdown Component
#8528
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/76b87225d50105ee211814ade0222d719faef616/gradio-4.36.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@76b87225d50105ee211814ade0222d719faef616#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/76b87225d50105ee211814ade0222d719faef616/gradio-client-1.1.1.tgz |
js/markdown/shared/Markdown.svelte
Outdated
@@ -30,6 +31,7 @@ | |||
data-testid="markdown" | |||
dir={rtl ? "rtl" : "ltr"} | |||
use:copy | |||
style="max-height: {height}; overflow-y: auto;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this style should only be applied if the height is not null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made suggested changes and would request you to review and share your thoughts! :)
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
height
and overflow scrollbar for the Markdown Component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for this nice PR @ShruAgarwal! I made some tweaks for consistency with other components e.g. to make the height
parameter also be able to accept an int.
Thanks a lot, @abidlabs ! 🤗😀 |
Description
Adds an option to enable the
height
parameter(type: str)
for a scrollable markdown. This can be used for controlling the display size of this component.Please run
demo/markdown_example
to see it in action.I kindly request you @abidlabs to please review this change and let me know your feedback! 🙂
Closes: #7455
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh