Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gr.Dropdown(multiselect=False)
sets the default value as[]
of typelist
. It's a confusing behavior.The fix is in a04ad54 where the default value is changed from
[]
toundefined
.As a result, the following
value
initializer that seems to have not been reached before became effective and the first item ofchoices
is now set as the default value.gradio/js/dropdown/shared/Dropdown.svelte
Lines 59 to 65 in 0ab6ac5
I think
[]
as the default value of a single-select dropdown is obviously a bug.choices
instead ofNone
is an opinionated behavior, while I think it's desirable as the user can eliminate the null-checking from the user-definedfn
. If it's a problem I will fix it.For example,
the tone generator example looks like this, where the non-null dropdown value is set by default: