Fix Lite to work on FireFox #9527
Closed
+10
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e URL and pass the bypassed blob directly, because the current approach doesn't work on FireFox where new WebWorker() throws the SecurityError asynchronously so we can't catch it with synchronous try-catch
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/e01c6c73bbff5759cdba387bb8f19060c54684bc/gradio-4.44.1-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@e01c6c73bbff5759cdba387bb8f19060c54684bc#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/e01c6c73bbff5759cdba387bb8f19060c54684bc/gradio-client-1.6.0-beta.3.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/e01c6c73bbff5759cdba387bb8f19060c54684bc/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Supersedded by #9528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context: internal link
Lite doesn't work on FireFox when the script is loaded in the cross-origin manner as below (this screenshot was taken in an env where the Lite is served from
localhost:8000and the parent page is fromlocalhost:8080).This is because, on FireFox,
new WebWorker()throws theSecurityErrorasynchronously, while it's synchronous on Chrome, so the synchronoustry-catchsurrounding it doesn't work.We have been using the normal initializer
new WebWorker(url)first and the cross-origin initializer as a fall-back,but in this PR we gave up using the normal one and switched to use the cross-origin one in any cases for simplicity sake.