Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown code copy/check button in gr.Chatbot #9598

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Oct 8, 2024

Description

Not sure which PR caused this issue in 5.0-dev - it happened while Chromatic was down (due to our plan) so it went through unnoticed at some point. This PR fixes and cleans it up a bit. I think we could go down a path of revisiting this design-wise as discussed for chatbot but this fixes it for now.

5.0-dev new
image image Screenshot 2024-10-09 at 00 30 36 Screenshot 2024-10-09 at 00 30 38

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 8, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/ab5bb4831d7bd3aa6d9e214d866d767d8ba47960/gradio-4.44.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ab5bb4831d7bd3aa6d9e214d866d767d8ba47960#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/ab5bb4831d7bd3aa6d9e214d866d767d8ba47960/gradio-client-1.6.0-beta.4.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/ab5bb4831d7bd3aa6d9e214d866d767d8ba47960/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 8, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot minor
@gradio/markdown minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix markdown code copy/check button in gr.Chatbot

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, lgtm! Thanks @hannahblair

@abidlabs abidlabs merged commit ffc33fa into 5.0-dev Oct 9, 2024
23 of 25 checks passed
@abidlabs abidlabs deleted the fix-markdown-copy-btn branch October 9, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants