Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Audio in Chatbot bug #9676

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Fix Audio in Chatbot bug #9676

merged 5 commits into from
Oct 11, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Oct 11, 2024

Description

For some reason, this only broke the audio component. But the same error gets raised for all components.

Fixes #9664

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@freddyaboulton freddyaboulton marked this pull request as ready for review October 11, 2024 22:50
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 11, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/69bb7be96ec6706474cac51e55d2bafda54c1152/gradio-5.0.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@69bb7be96ec6706474cac51e55d2bafda54c1152#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/69bb7be96ec6706474cac51e55d2bafda54c1152/gradio-client-1.6.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/69bb7be96ec6706474cac51e55d2bafda54c1152/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 11, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Audio in Chatbot bug

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Confirmed with a simple repro:

import gradio as gr

with gr.Blocks() as demo:
    gr.Chatbot([{"role": "user", "content": gr.Audio("test.wav")}], type="messages")

demo.launch()

Nice @freddyaboulton!

@freddyaboulton
Copy link
Collaborator Author

Thanks @abidlabs ! We have e2e tests for this too

@freddyaboulton freddyaboulton merged commit fd0264f into main Oct 11, 2024
19 of 24 checks passed
@freddyaboulton freddyaboulton deleted the fix-chatbot-audio-load branch October 11, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio Chat Messages Fail To Render in 5.0.1
3 participants