Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend errors on ApiDocs and RecordingSnippet #9786

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Oct 22, 2024

Description

Found these errors and this PR fixes them.

API recorder

After recording the API calls, the api call sample code should be displayed but wasn't.

Before This PR

CleanShot 2024-10-22 at 17 14 08@2x

CleanShot 2024-10-22 at 17 15 11@2x

Close button

Clicking this close button causes this error in the dev console.

CleanShot 2024-10-22 at 17 11 45@2x

CleanShot 2024-10-22 at 17 17 33@2x

Blocks.svelte:809 Uncaught TypeError: Cannot read properties of null (reading 'api_recorder_visible')
    at Do.Ws (Blocks.svelte:809:42)
    at svelte.js:2042:40
    at Array.forEach (<anonymous>)
    at Do.bubble (svelte.js:2042:21)
    at Do.k (ApiDocs.svelte:96:35)
    at svelte.js:1966:8
    at Array.forEach (<anonymous>)
    at svelte.js:1965:22
    at HTMLButtonElement.a (ApiBanner.svelte:38:25)

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 22, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/63d2c059f5b516539a5f5729fd4109e5ce5c6d57/gradio-5.4.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@63d2c059f5b516539a5f5729fd4109e5ce5c6d57#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/63d2c059f5b516539a5f5729fd4109e5ce5c6d57/gradio-client-1.7.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/63d2c059f5b516539a5f5729fd4109e5ce5c6d57/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 22, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/core minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix frontend errors on ApiDocs and RecordingSnippet

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx requested review from abidlabs and pngwn October 22, 2024 08:18
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitphx is this still meant to be in draft?

I tried and confirmed it fixes the first error. Guess we forgot about api_prefix here when we merged 5.0

I couldn't actually reproduce the error with the close button, though the change looks good to me!

@whitphx whitphx marked this pull request as ready for review November 2, 2024 08:55
@whitphx
Copy link
Member Author

whitphx commented Nov 2, 2024

@aliabd sorry this is ready for review, and you already approved it, thanks.

@whitphx whitphx merged commit f109497 into main Nov 2, 2024
23 of 24 checks passed
@whitphx whitphx deleted the fix-api-docs branch November 2, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants