-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix frontend errors on ApiDocs and RecordingSnippet #9786
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/63d2c059f5b516539a5f5729fd4109e5ce5c6d57/gradio-5.4.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@63d2c059f5b516539a5f5729fd4109e5ce5c6d57#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/63d2c059f5b516539a5f5729fd4109e5ce5c6d57/gradio-client-1.7.1.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/63d2c059f5b516539a5f5729fd4109e5ce5c6d57/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whitphx is this still meant to be in draft?
I tried and confirmed it fixes the first error. Guess we forgot about api_prefix here when we merged 5.0
I couldn't actually reproduce the error with the close button, though the change looks good to me!
@aliabd sorry this is ready for review, and you already approved it, thanks. |
Description
Found these errors and this PR fixes them.
API recorder
After recording the API calls, the api call sample code should be displayed but wasn't.
Close button
Clicking this close button causes this error in the dev console.