support gradio apps on spaces served on subpaths #9814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pngwn
added
t: fix
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/abe2acb6c0383de922f73be38280737268b11408/gradio-5.3.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@abe2acb6c0383de922f73be38280737268b11408#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/abe2acb6c0383de922f73be38280737268b11408/gradio-client-1.7.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/abe2acb6c0383de922f73be38280737268b11408/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
pngwn
changed the title
hannahblair
reviewed
Oct 23, 2024
Comment on lines
-185
to
-191
| if (host.endsWith("hf.space")) { | ||
| return { | ||
| ws_protocol: "wss", | ||
| host: host, | ||
| http_protocol: protocol as "http:" | "https:" | ||
| }; | ||
| } |
There was a problem hiding this comment.
why didnt we need this?
hannahblair
reviewed
Oct 23, 2024
| @@ -486,6 +486,18 @@ describe("process_endpoint", () => { | |||
| expect(response.space_id).toBe("hmb-hello-world"); | |||
| expect(response.host).toBe("hmb-hello-world.hf.space"); | |||
| }); | |||
|
|
|||
| it("handles huggingface subpath urls", async () => { | |||
hannahblair
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible to be using a subpath URL even when hosting on spaces which the client doesn't currently take into account. I have tweaked the client to support this.
This is what was breaking our demo space.