Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure non-form elements are correctly positioned when scale is applied #9882

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Oct 31, 2024

Description

Non-form elements are being positioned centrally when scale is applied, while form elements are positioned to the left. I assume this is the correct behaviour - in 4.44.1, the elements would all left align. I'm not sure where exactly this changed in 5.x however.

Closes: #9866

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 31, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/c7f02ca005c94806b7ce4df338a277f235b89196/gradio-5.4.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c7f02ca005c94806b7ce4df338a277f235b89196#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/c7f02ca005c94806b7ce4df338a277f235b89196/gradio-client-1.7.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/c7f02ca005c94806b7ce4df338a277f235b89196/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 31, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/atoms patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Ensure non-form elements are correctly positioned when scale is applied

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair marked this pull request as ready for review November 1, 2024 16:58
Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM works great, thanks! Do you know when we'd need the auto-margin class btw? When does the Block need to be centered like that.

@hannahblair
Copy link
Collaborator Author

Do you know when we'd need the auto-margin class btw? When does the Block need to be centered like that.

Good question, I don't think we need it, though I'm erring on the side of caution 😅

@hannahblair hannahblair merged commit 6c8a064 into main Nov 4, 2024
24 checks passed
@hannahblair hannahblair deleted the block-form-positioning branch November 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File component does not left align in rows in version 5 of Gradio anymore when using scale 0
3 participants