Make staging repo description configurable #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description can now be customized on the extension or individual tasks and now defaults to the GAV of the root project. Resolves #31.
marcphilipp
force-pushed
the
marc/31-configurable-description
branch
from
abc2fd3 to
601a78a
Compare
szpak
requested changes
May 31, 2020
| @@ -186,6 +189,9 @@ tasks { | |||
| useJUnitPlatform() | |||
| maxParallelForks = 8 | |||
| } | |||
| withType<Test>().matching { it.name.startsWith("compatTest") }.configureEach { | |||
| systemProperty("plugin.version", project.version) | |||
There was a problem hiding this comment.
We can probably set for all the tests, not just compatTest (to reuse the previous section in build.gradle).
There was a problem hiding this comment.
I didn't want to add an unnecessary input to the other test tasks.
src/main/kotlin/io/github/gradlenexus/publishplugin/internal/NexusClient.kt
Outdated
Show resolved
Hide resolved
szpak
approved these changes
May 31, 2020
|
@marcphilipp You have some style violations. |
marcphilipp
force-pushed
the
marc/31-configurable-description
branch
from
49395c2 to
14512e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description can now be customized on the extension or individual
tasks and now defaults to the GAV of the root project.
In addition, the User-Agent (which is shown in Nexus UI) is now
customized to
gradle-nexus-publish-plugin/<version>.Resolves #31.