Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Actions doesn't see gradle with version 8.10 #340

Closed
ylazakovich opened this issue Aug 14, 2024 · 4 comments
Closed

🐞 Actions doesn't see gradle with version 8.10 #340

ylazakovich opened this issue Aug 14, 2024 · 4 comments

Comments

@ylazakovich
Copy link

     - name: Set up JDK
        uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018 # v4
        with:
          distribution: "corretto"
          cache: "gradle"
          java-version: "17"
      - name: Build with Gradle
        uses: gradle/actions/setup-gradle@af1da67850ed9a4cedd57bfd976089dd991e2582 # v4
        with:
          gradle-version: 8.10

As result uses gradle of version 8.1 instead of 8.10
image

ylazakovich added a commit to ylazakovich/path-of-exile-starter that referenced this issue Aug 14, 2024
- If use arg gradle-version 8.10 as result action will call gradle 8.1
- see gradle/actions#340
@tbroyer
Copy link

tbroyer commented Aug 14, 2024

This is likely a YAML gotcha: it's interpreted by the YAML parser as a number, you'd want to quote it so it's taken as a string.

@ylazakovich
Copy link
Author

Confirm, you are right

Thanks @tbroyer!
I think issue is not relevant and can be closed

image

@bigdaz
Copy link
Member

bigdaz commented Aug 15, 2024

Thanks for the report, and thanks @tbroyer for the diagnosis.
Before closing this I'll see if there's any way for the action to influence the way the gradle-version input is interpreted, but I suspect there's not much the action can do.

@bigdaz
Copy link
Member

bigdaz commented Aug 26, 2024

This value is converted by YAML before the action has any chance to do anything.
I'll update our docs to quote the Gradle version, but I don't think there's much else that can be done.

@bigdaz bigdaz closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants