Fix delete preview comment domain #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
requested changes
Nov 15, 2024
| @@ -33,4 +33,4 @@ jobs: | |||
| number: ${{ github.event.number }} | |||
| id: deploy-preview | |||
| message: > | |||
| 🪓 PR closed, deleted preview at https://github.com/${{ env.PREVIEW_REPO }}/tree/gh-pages/${{ env.PPREVIEW_PATH }}/ | |||
| 🪓 PR closed, deleted preview at https://${{ env.PREVIEW_DOMAIN}}/${{ env.PREVIEW_REPO }}/tree/gh-pages/${{ env.PPREVIEW_PATH }}/ | |||
There was a problem hiding this comment.
Suggested change
| 🪓 PR closed, deleted preview at https://${{ env.PREVIEW_DOMAIN}}/${{ env.PREVIEW_REPO }}/tree/gh-pages/${{ env.PPREVIEW_PATH }}/ | |
| 🪓 PR closed, deleted preview at https://github.com/gradle/${{ env.PREVIEW_REPO }}/tree/gh-pages/${{ env.PREVIEW_PATH }}/ |
There was a problem hiding this comment.
Now I got the whole thing 😅
Sorry.
However, why can't we use the same thing on as we do on ci? 🤔
https://${{ env.PREVIEW_DOMAIN }}/${{ env.PREVIEW_REPO }}/${{ env.PREVIEW_PATH}}/
This is actually what I would expect...
|
When we publish the site, it is served from GitHub pages. When we delete
the preview, then github is the only things we have left. Maybe the easiest
approach is to just just not include any link in the deletion message.
…On Fri, Nov 15, 2024, 11:23 Stefan M. ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/preview-cleanup.yml
<#125 (comment)>:
> @@ -33,4 +33,4 @@ jobs:
number: ${{ github.event.number }}
id: deploy-preview
message: >
- 🪓 PR closed, deleted preview at https://github.com/${{ env.PREVIEW_REPO }}/tree/gh-pages/${{ env.PPREVIEW_PATH }}/
+ 🪓 PR closed, deleted preview at https://${{ env.PREVIEW_DOMAIN}}/${{ env.PREVIEW_REPO }}/tree/gh-pages/${{ env.PPREVIEW_PATH }}/
Now I got the whole thing 😅
Sorry.
However, why can't we use the same thing on as we do on ci? 🤔
https://${{ env.PREVIEW_DOMAIN }}/${{ env.PREVIEW_REPO }}/${{
env.PREVIEW_PATH}}/
This is actually what I would expect...
—
Reply to this email directly, view it on GitHub
<#125 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIGKI7DRXPNMAOYLBNT2AXDS5AVCNFSM6AAAAABR2PXYW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZYGIZDQNZRGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
*
CONFIDENTIALITY NOTICE*: The contents of this email message, and any
attachments, are intended solely for the addressee(s) and may contain
confidential, proprietary and/or privileged information legally protected
from disclosure. If you are not the intended recipient of this
communication, or if you received this communication by mistake, please
notify the sender immediately and delete this message and any attachments.
If you are not the intended recipient, you are hereby notified that any
use, retransmission, dissemination, copying or storage of this message or
its attachments is strictly prohibited.
|
|
... Or referencing the actual deployment, e.g. community.gradle.org . " The
preview was deleted but you now can find the content on the main site"
…On Fri, Nov 15, 2024, 12:54 Oleg Nenashev ***@***.***> wrote:
When we publish the site, it is served from GitHub pages. When we delete
the preview, then github is the only things we have left. Maybe the easiest
approach is to just just not include any link in the deletion message.
On Fri, Nov 15, 2024, 11:23 Stefan M. ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In .github/workflows/preview-cleanup.yml
> <#125 (comment)>:
>
> > @@ -33,4 +33,4 @@ jobs:
> number: ${{ github.event.number }}
> id: deploy-preview
> message: >
> - 🪓 PR closed, deleted preview at https://github.com/${{ env.PREVIEW_REPO }}/tree/gh-pages/${{ env.PPREVIEW_PATH }}/
> + 🪓 PR closed, deleted preview at https://${{ env.PREVIEW_DOMAIN}}/${{ env.PREVIEW_REPO }}/tree/gh-pages/${{ env.PPREVIEW_PATH }}/
>
> Now I got the whole thing 😅
> Sorry.
>
> However, why can't we use the same thing on as we do on ci? 🤔
> https://${{ env.PREVIEW_DOMAIN }}/${{ env.PREVIEW_REPO }}/${{
> env.PREVIEW_PATH}}/
> This is actually what I would expect...
>
> —
> Reply to this email directly, view it on GitHub
> <#125 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAW4RIGKI7DRXPNMAOYLBNT2AXDS5AVCNFSM6AAAAABR2PXYW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZYGIZDQNZRGY>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
--
*
CONFIDENTIALITY NOTICE*: The contents of this email message, and any
attachments, are intended solely for the addressee(s) and may contain
confidential, proprietary and/or privileged information legally protected
from disclosure. If you are not the intended recipient of this
communication, or if you received this communication by mistake, please
notify the sender immediately and delete this message and any attachments.
If you are not the intended recipient, you are hereby notified that any
use, retransmission, dissemination, copying or storage of this message or
its attachments is strictly prohibited.
|
|
The directory is deleted after the merge, right? So the content is also gone? This means the link currently leads to a non-existent directory, correct? 🤔 Having a link to a non-existent directory doesn’t make sense. I thought my fix was meant to indicate, "This deployment was deleted, so it's no longer available." Well, I’m not sure if that helps, but at least it matches the initial GitHub Actions comment saying, "It was deployed to." That said, I agree with you that maybe it would be better to omit the link altogether. Why say something like, "It was there, but not anymore"? It doesn’t provide any useful information. Perhaps a better approach would be to check if the PR was merged. If it was, we could say, "Deployment deleted; content is available at [Main URL]." If the PR was closed without merging, we could say, "Preview deleted." I’ll update my PR with that tomorrow. 🙃 |
|
Code update ✅ |
|
Thank you ! |
oleg-nenashev
approved these changes
Nov 17, 2024
|
CI seems to be failing because it uses secrets.GITHUB_TOKEN under the hood. Forks doesn't have access to it 😔 |
|
Yes, it is something to reconfigure. Will do it when I have access from my
work laptop
…On Sun, Nov 17, 2024, 19:56 Stefan M. ***@***.***> wrote:
CI seems to be failing because it uses secrets.GITHUB_TOKEN under the
hood. Forks doesn't have access to it 😔
—
Reply to this email directly, view it on GitHub
<#125 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIFT6QD4NEUVUZO43A32BDRE3AVCNFSM6AAAAABR2PXYW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBRGQZDSOJVHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
*
CONFIDENTIALITY NOTICE*: The contents of this email message, and any
attachments, are intended solely for the addressee(s) and may contain
confidential, proprietary and/or privileged information legally protected
from disclosure. If you are not the intended recipient of this
communication, or if you received this communication by mistake, please
notify the sender immediately and delete this message and any attachments.
If you are not the intended recipient, you are hereby notified that any
use, retransmission, dissemination, copying or storage of this message or
its attachments is strictly prohibited.
|
|
Raised #128 , will merge it for now as it should work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor change to the
.github/workflows/preview-cleanup.ymlfile. The change updates the URL format in the message for deleting a preview when a pull request is closed..github/workflows/preview-cleanup.yml: Updated the URL format in themessagefield to usePREVIEW_DOMAINfor constructing the preview URL.