Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples and scripts to use DV Maven extension 1.21 and DV API #1121

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

runningcode
Copy link
Contributor

@runningcode runningcode commented Apr 5, 2024

This also fixes the maven build caching samples, the maven data capturing samples, the maven rollout script, the creating a maven distribution training.

The build caching samples are not working due to what seems like a bug in the BVS.

@runningcode runningcode changed the title Update to use DV Maven extension 1.21 and DV API Update samples and scripts to use DV Maven extension 1.21 and DV API Apr 5, 2024
@clayburn
Copy link
Member

clayburn commented Apr 5, 2024

Regarding the failing Maven Build Caching Sample: https://ge.solutions-team.gradle.com/c/n26q3qjmlrujs/ad4vg3vhutpw4/goal-inputs?cacheability=cacheable

I've seen this builddef.lst miss before. This is the issue from the aspectj plugin, which is not resolved. That builddef.lst file I believe is just an output of the AjcCompileMojo that contains the configuration of that compilation. A goal like surefire could safely ignore that file with normalization I believe.

The real question to me though is what about this change causes this to occur? My best guess is that it is the -e workaround, since it will inject the legacy Gradle Enterprise Maven Extension 1.18.1. I tried this locally (manually) using the Develocity Maven Extension 1.21 and could not reproduce the cache miss: https://ge.solutions-team.gradle.com/c/riufudxr7zxtg/hv2kwnj2l2xwm/goal-inputs

It isn't clear to me why this is the only case that would break. I think we really need an updated Build Validation Scripts that doesn't require this workaround to make the most sense of this.

Signed-off-by: Nelson Osacky <nosacky@gradle.com>
@runningcode
Copy link
Contributor Author

I think we should have updated samples as soon as we can. Given BVS are frozen, I see two ways forward,

  1. Disable the failing test for now
  2. Undo the changes to the caching samples until this is resolved

I think we should go for 1, what do you think @erichaagdev @clayburn ?

@clayburn
Copy link
Member

clayburn commented Apr 8, 2024

Option 1 sounds fine, let's just make sure we track it so it does not stay ignored forever.

@runningcode
Copy link
Contributor Author

Here's a link to the internal issue to re-enable the workflow: https://github.com/gradle/ge/issues/34353

@runningcode runningcode merged commit 3c60c0e into main Apr 9, 2024
20 checks passed
@runningcode runningcode deleted the no/update-maven-extension branch April 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants