Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Androidx cache misses on :biometric:integration-tests:testapp #87

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jprinet
Copy link
Member

@jprinet jprinet commented Nov 30, 2023

Issue

Androidx has some new cache misses on experiment 3

Reason

The Build Scan comparison shows that MergeResources.resourceDirsOutsideRootProjectDir is the changing input

The code documents that this property will make the task not relocatable when not empty with view binding enabled.

Interestingly enough, since this commit the resourceDir and the rootDir differs making the property not empty with absolute paths.

Fix

Make the tasks not cacheable with a Git hook

MergeResources and DataBindingGenBaseClassesTask are not cache relocatable when sourceSets are not in rootDir
@jprinet jprinet changed the title Fix Androidx cache misses on :biometric:integration-tests:testapp Ignore Androidx cache misses on :biometric:integration-tests:testapp Nov 30, 2023
@jprinet jprinet merged commit 3c87bbc into main Dec 4, 2023
1 check passed
@jprinet jprinet deleted the jprinet/fix-androidx-cache-miss branch December 4, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants