Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade XWiki to JDK 17 and MVN 3.9.6 as per project requirements #90

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Upgrade XWiki to JDK 17 and MVN 3.9.6 as per project requirements #90

merged 1 commit into from
Jan 10, 2024

Conversation

jprinet
Copy link
Member

@jprinet jprinet commented Jan 9, 2024

Issue

Xwiki build is currently failing because

  • JDK 17 is required
  • mvn 3.9.6 is required not to be exposed to this

Fix

Use setup-maven-action to address both requirements

@jprinet jprinet requested a review from runningcode January 9, 2024 17:43
runningcode
runningcode approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this

@jprinet jprinet merged commit 0329571 into main Jan 10, 2024
1 check passed
@jprinet jprinet deleted the jprinet/fix-xwiki-build-failure-on-enforcer branch January 10, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runningcode runningcode runningcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprinet @runningcode