generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for version 3.x #968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR ready for review: https://gradle.com/s/uv3aipsr67thq |
bigdaz
force-pushed
the
prerelease/v3
branch
2 times, most recently
from
December 13, 2023 20:41
fae01e6
to
5fe1135
Compare
bigdaz
force-pushed
the
prerelease/v3
branch
from
December 20, 2023 17:12
21bee38
to
7a51d6f
Compare
bigdaz
force-pushed
the
prerelease/v3
branch
3 times, most recently
from
December 21, 2023 02:02
2a46a56
to
85de0aa
Compare
bigdaz
force-pushed
the
prerelease/v3
branch
from
December 21, 2023 02:51
22447e1
to
4cc7f82
Compare
This makes it easier for users to enable config-cache saving in their workflow. Config-cache data will only be saved/restored when the key is provided, and the key is exported as `GRADLE_ENCRYPTION_KEY` for use in subsequent steps.
- Rename test for clarity - Use cache-encryption-key in config-cache test
bigdaz
force-pushed
the
prerelease/v3
branch
3 times, most recently
from
December 23, 2023 06:08
d012ec2
to
00214bf
Compare
- Avoid logging "not restoring" message when no entries exist to restore - Clear the entries from metadata when they are not restored. This ensures that the non-restored entries are correctly purged.
- Filter out config-cache directories that do not exist when constructing cache entry definitions
Earlier versions of Gradle didn't support the `GRADLE_ENCRYPTION_KEY` for the configuration-cache, and so are either not useful to save, or are actually unsafe due to unencrypted secrets. We use semver to compare the Gradle version used to produce the config-cache entry with the minimum Gradle version required.
bigdaz
force-pushed
the
prerelease/v3
branch
from
December 23, 2023 16:29
00214bf
to
d691d98
Compare
Config-cache save/restore is dependent on Gradle 8.6. Use of the release-nightly is temporary until 8.6 is released.
- Avoid "Entry not saved: reason unknown" when entry was not restored - Avoid "Entry not saved: Encryption key not provided" when no config-cache data found - Avoid spurious log message when no config-cache data found
- Deprecate `build-root-directory` and `gradle-executable` parameters - Remove examples from README
bigdaz
force-pushed
the
prerelease/v3
branch
from
December 23, 2023 19:31
5dc8c5a
to
e6566cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains all functionality planned for the initial 3.x release.
arguments
parameter #996