Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use canonical paths for temp-files #222

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Use canonical paths for temp-files #222

merged 2 commits into from
Jul 24, 2020

Conversation

wolfs
Copy link
Member

@wolfs wolfs commented Jul 24, 2020

when they are inputs to the build. We currently can't watch symlinks on macOS, since we get the events for the canonical path. /var is a symlink to /private/var on macOS, and the tmp dir is in /var.

when they are inputs to the build. We currently can't watch
symlinks on macOS, since we get the events for the canonical
path. `/var` is a symlink to `/private/var` on macOS, and
the tmp dir is in `/var`.
Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't make a difference since this init script is not present
when profiling. It is probably a good idea nonetheless.
@wolfs
Copy link
Member Author

wolfs commented Jul 24, 2020

Shouldn't we be also doing the same in https://github.com/gradle/gradle-profiler/blob/08a96120f0a22c999a652e6e605eb1d4c0803d0c/src/main/java/org/gradle/profiler/DefaultGradleBuildConfigurationReader.java#L37❓

I did that, though it shouldn't make a difference since the init script is only loaded for probing and not for profiling. Moreover, the init script itself is not read via the VFS (yet), Gradle only uses the compiled init script which is in the Gradle user home.

@eskatos Do you have any idea if we still need this file: https://github.com/gradle/gradle-profiler/blob/0a72d39cadfba7114f28043b5ebaac28a5964d73/subprojects/chrome-trace/init.gradle

@wolfs wolfs merged commit a59d487 into master Jul 24, 2020
@wolfs wolfs deleted the wolfs/canonicalized-paths branch July 24, 2020 11:10
@eskatos
Copy link
Member

eskatos commented Jul 24, 2020

@eskatos Do you have any idea if we still need this file: https://github.com/gradle/gradle-profiler/blob/0a72d39cadfba7114f28043b5ebaac28a5964d73/subprojects/chrome-trace/init.gradle

It's not used by anything in the build. I think it's been added as a convenience to use the chrome trace plugin from a clone of this repo. I never used it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants