Better HTML report model #254
Conversation
| // Initialize sample config | ||
| benchmarkResult.scenarios.forEach((scenario, scenarioIndex, scenarios) => { | ||
| scenario.samples.forEach((sample, sampleIndex, samples) => { | ||
| sample.color = `hsl(${scenarioIndex * 360 / scenarios.length}, ${100 - 80 * sampleIndex / samples.length}%, ${30 + 40 * sampleIndex / samples.length}%)`; |
There was a problem hiding this comment.
I find the shades of red/green very hard to distinguish:
Do you have any better ideas what colors to use?
There was a problem hiding this comment.
Not sure how important it is to distinguish the different shades of green (=different build operations for the same experiment), it seems more important to distinguish the green from the red (same build operations for different experiments).
There was a problem hiding this comment.
That said I'm open to suggestions.
| let maxMeasuredIterations = Math.max(...(benchmarkResult.scenarios.map(scenario => iterations(scenario, Phase.MEASURE).length))); | ||
| let chart = new Chart(ctx, { | ||
| type: 'line', | ||
| var app = new Vue({ |
There was a problem hiding this comment.
| var app = new Vue({ | |
| const app = new Vue({ |
No need to leave this mutable.
There was a problem hiding this comment.
I've fixed this and others.
| @@ -148,12 +142,21 @@ | |||
| </div> | |||
| </div> | |||
| <footer> | |||
| <span>Gradle Profiler version {{ environment.profilerVersion }}</span> | |||
| <span>Gradle Profiler version {{ benchmarkResult.environment.profilerVersion }}</span> | |||
| </footer> | |||
| </div> | |||
| <script> | |||
| Array.prototype.unique = function() { return [...new Set(this)]; }; | |||
There was a problem hiding this comment.
The unique function is now unused.
There was a problem hiding this comment.
I removed it and moved the utility functions into Array prototype functions.
| } | ||
| } | ||
| }; | ||
|
|
||
| function convertScenarioToChart(scenario, sample, sorted, color) { | ||
| var data = iterations(scenario, Phase.MEASURE) |
There was a problem hiding this comment.
| var data = iterations(scenario, Phase.MEASURE) | |
| const data = iterations(scenario, Phase.MEASURE) |
Vue.js allows us to better model things. Let's make use of it.
test-report.html.zip