-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release automatically to SDKMAN #276
Conversation
so we only announce and set the default version for a final release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we need to better document this though.
|
||
tasks.register("releaseToSdkMan") { | ||
val versionString = project.version.toString() | ||
val isFinalRelease = Regex("""[0-9\.]*""").matchEntire(versionString) != null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use a bit of commenting. And it would be great to mention the release logic and the fact that we are publishing to SDKMAN in the RELEASING.md
. That file is in dire need of updating anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment and updated the release instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think the way the version number format controls the SDKMAN publishing behavior should also be mentioned in RELEASING.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it the releasing instructions as well.
@lptr PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Publishes releases automatically to SDKMAN.