Normalize stack frames with Lambda class names #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lambda names are auto-generated and change from build to build. This makes it difficult to compare flamegraphs since the stack may look very different but ultimately be exactly the same
wolfs
reviewed
Feb 26, 2021
| protected String mapFrame(String frame) { | ||
| // Lambdas contain a name that's based on an index + timestamp at runtime and changes build-to-build. | ||
| // This makes comparing two builds very difficult when a lambda is in the stack | ||
| return frame.replaceFirst(Pattern.quote("$$Lambda$")+"[0-9/]+", "\\$\\$Lambda\\$"); |
There was a problem hiding this comment.
Suggested change
| return frame.replaceFirst(Pattern.quote("$$Lambda$")+"[0-9/]+", "\\$\\$Lambda\\$"); | |
| return frame.replaceFirst(Pattern.quote("$$Lambda$")+"[0-9./]+", "\\$\\$Lambda\\$"); |
Can you leave the . and the /? That way we also normalize Lambdas for different Java versions correctly.
. and / are used depending on JVM version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambda names are auto-generated and change from build to build. This
makes it difficult to compare flamegraphs since the stack may look very
different but ultimately be exactly the same