Add option to run Android Studio sync with clean IDE cache #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfs
reviewed
Nov 16, 2021
src/main/java/org/gradle/profiler/studio/process/StudioProcessController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gradle/profiler/studio/process/StudioProcessController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gradle/profiler/studio/process/StudioProcessController.java
Outdated
Show resolved
Hide resolved
asodja
force-pushed
the
asodja/studio-fresh-state
branch
from
20d53df
to
b3979c1
Compare
wolfs
reviewed
Nov 19, 2021
| @@ -10,6 +10,7 @@ public String toString() { | |||
| } | |||
| }; | |||
| static final GradleBuildInvoker AndroidStudio = new GradleBuildInvoker(GradleClientSpec.AndroidStudio, GradleDaemonReuse.WarmDaemonOnly); | |||
| static final GradleBuildInvoker AndroidStudioFirstSync = new GradleBuildInvoker(GradleClientSpec.AndroidStudioFirstSync, GradleDaemonReuse.ColdDaemonOnly); | |||
There was a problem hiding this comment.
How does the ColdDaemonOnly come into play here? I expect Android Studio to re-use the daemon via the tooling API, so it wouldn't be a could daemon, right?
There was a problem hiding this comment.
Android Studio does not re-use daemon after the restart. So it always starts with the cold daemon in that case: I noticed that because we have checks in the gradle-profiler, that in case WarmDaemonOnly is set but daemon is not reused then an exception is thrown.
Co-authored-by: Stefan Wolf <wolf@gradle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.