-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to run Android Studio sync with clean IDE cache #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
src/main/java/org/gradle/profiler/studio/process/StudioProcessController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gradle/profiler/studio/process/StudioProcessController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gradle/profiler/studio/process/StudioProcessController.java
Outdated
Show resolved
Hide resolved
20d53df
to
b3979c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, I left two small comments.
@@ -10,6 +10,7 @@ public String toString() { | |||
} | |||
}; | |||
static final GradleBuildInvoker AndroidStudio = new GradleBuildInvoker(GradleClientSpec.AndroidStudio, GradleDaemonReuse.WarmDaemonOnly); | |||
static final GradleBuildInvoker AndroidStudioFirstSync = new GradleBuildInvoker(GradleClientSpec.AndroidStudioFirstSync, GradleDaemonReuse.ColdDaemonOnly); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the ColdDaemonOnly
come into play here? I expect Android Studio to re-use the daemon via the tooling API, so it wouldn't be a could daemon, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android Studio does not re-use daemon after the restart. So it always starts with the cold daemon in that case: I noticed that because we have checks in the gradle-profiler, that in case WarmDaemonOnly
is set but daemon is not reused then an exception is thrown.
Co-authored-by: Stefan Wolf <wolf@gradle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.