Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android Studio Giraffe (2022.3) #472

Merged
merged 6 commits into from
Feb 3, 2023
Merged

Conversation

asodja
Copy link
Member

@asodja asodja commented Feb 1, 2023

By using newer APIs. Good news is that all these APIs are also in other versions we support (Chipmunk and newer), so this also works with previous versions.

Fixes #469
Fixes #470

@asodja asodja marked this pull request as draft February 1, 2023 09:45
@asodja asodja self-assigned this Feb 1, 2023
@asodja asodja force-pushed the asodja/as-2023.1 branch 2 times, most recently from 5f865e8 to 10135bf Compare February 1, 2023 10:13
…eadActionInSmartMode in waitOnBackgroundProcessesFinish

Making GradleProfilerStartupActivity DumbAware makes sure it is started right away, even if there is some indexing running.
DumbService.runReadActionInSmartMode makes sure we wait on indexing to end in waitOnBackgroundProcessesFinish even.
@asodja asodja changed the title Add support for Android Studio Giraffe (2023.1) Add support for Android Studio Giraffe (2022.3) Feb 1, 2023
@asodja asodja force-pushed the asodja/as-2023.1 branch 14 times, most recently from 61b6aa8 to 8511585 Compare February 2, 2023 15:28
@asodja asodja force-pushed the asodja/as-2023.1 branch 2 times, most recently from 6ff660f to 9ef1aae Compare February 2, 2023 16:39
@asodja asodja requested a review from a team February 2, 2023 19:21
@asodja asodja marked this pull request as ready for review February 2, 2023 19:21
Copy link
Member

@lptr lptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

build.gradle.kts Show resolved Hide resolved
@asodja asodja merged commit 1427d60 into master Feb 3, 2023
@blindpirate blindpirate deleted the asodja/as-2023.1 branch February 5, 2023 07:03
@blindpirate
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android Studio sync doesn't work with Android Studio Giraffe Test failures with Oracle Java 8, new Intel mac
3 participants