-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Android Studio Giraffe (2022.3) #472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asodja
force-pushed
the
asodja/as-2023.1
branch
2 times, most recently
from
February 1, 2023 10:13
5f865e8
to
10135bf
Compare
By using newer APIs
…eadActionInSmartMode in waitOnBackgroundProcessesFinish Making GradleProfilerStartupActivity DumbAware makes sure it is started right away, even if there is some indexing running. DumbService.runReadActionInSmartMode makes sure we wait on indexing to end in waitOnBackgroundProcessesFinish even.
asodja
force-pushed
the
asodja/as-2023.1
branch
from
February 1, 2023 13:38
4af5555
to
688c9f8
Compare
asodja
changed the title
Add support for Android Studio Giraffe (2023.1)
Add support for Android Studio Giraffe (2022.3)
Feb 1, 2023
asodja
force-pushed
the
asodja/as-2023.1
branch
from
February 1, 2023 16:01
a3ba9c1
to
d1f6930
Compare
asodja
force-pushed
the
asodja/as-2023.1
branch
14 times, most recently
from
February 2, 2023 15:28
61b6aa8
to
8511585
Compare
asodja
force-pushed
the
asodja/as-2023.1
branch
2 times, most recently
from
February 2, 2023 16:39
6ff660f
to
9ef1aae
Compare
asodja
force-pushed
the
asodja/as-2023.1
branch
from
February 2, 2023 19:03
9ef1aae
to
1b0cabe
Compare
lptr
reviewed
Feb 2, 2023
buildSrc/src/main/kotlin/profiler.android-studio-setup.gradle.kts
Outdated
Show resolved
Hide resolved
src/test/groovy/org/gradle/profiler/AndroidStudioIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...plugin/src/main/java/org/gradle/profiler/studio/plugin/system/AndroidStudioSystemHelper.java
Show resolved
Hide resolved
asodja
force-pushed
the
asodja/as-2023.1
branch
from
February 3, 2023 14:08
a085dd5
to
18eb6bf
Compare
lptr
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using newer APIs. Good news is that all these APIs are also in other versions we support (Chipmunk and newer), so this also works with previous versions.
Fixes #469
Fixes #470