-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Maven wrapper #578
Use Maven wrapper #578
Conversation
Use it when it is available and a tool path is not specifically configured.
} | ||
|
||
@OverridingMethodsMustInvokeSuper | ||
protected String getExecutablePathWithoutToolHome(File projectDir) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 What if we pass projectDir to getExecutableName()
(and maybe we rename it?) so we have just one method instead of two (and also we can get rid of @OverridingMethodsMustInvokeSuper
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also use getExecutableName()
when looking up the executable from the tool home.
@Override | ||
protected String getExecutablePathWithoutToolHome(File projectDir) { | ||
String wrapperName = OperatingSystem.isWindows() | ||
? "mvnw.cmd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Should this be mvnw.bat
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's mvnw.cmd
, similar to mvn.cmd
a few lines above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use it when it is available and a tool path is not specifically configured.