Use Maven wrapper #578
Merged
Use Maven wrapper #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it when it is available and a tool path is not specifically configured.
asodja
reviewed
Sep 23, 2024
| } | ||
|
|
||
| @OverridingMethodsMustInvokeSuper | ||
| protected String getExecutablePathWithoutToolHome(File projectDir) { |
There was a problem hiding this comment.
🤔 What if we pass projectDir to getExecutableName() (and maybe we rename it?) so we have just one method instead of two (and also we can get rid of @OverridingMethodsMustInvokeSuper)?
There was a problem hiding this comment.
We also use getExecutableName() when looking up the executable from the tool home.
asodja
reviewed
Sep 23, 2024
| @Override | ||
| protected String getExecutablePathWithoutToolHome(File projectDir) { | ||
| String wrapperName = OperatingSystem.isWindows() | ||
| ? "mvnw.cmd" |
There was a problem hiding this comment.
No, it's mvnw.cmd, similar to mvn.cmd a few lines above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it when it is available and a tool path is not specifically configured.