Convert core/datastore project to use declarative buildscript #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tresat
changed the title
bamboo
reviewed
Jun 3, 2024
| } | ||
|
|
||
| testOptions { | ||
| returnDefaultValues = true |
There was a problem hiding this comment.
💅 It would be nicer if the Kotlin naming convention for boolean properties was preserved. People already have to deal with it when migrating from Groovy to Kotlin and this might add more friction.
There was a problem hiding this comment.
+1 to Rodrigo's comment!
@h0tk3y, could you please take care of creating an issue about making sure our schema extraction complies with Kotlin naming convention for boolean properties?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires gradle/declarative-gradle#84