Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ASM to 9.5 for Java 21 compatibility #182

Merged
merged 1 commit into from
May 22, 2023
Merged

Update ASM to 9.5 for Java 21 compatibility #182

merged 1 commit into from
May 22, 2023

Conversation

leonard84
Copy link
Member

No description provided.

@leonard84
Update ASM to 9.5 for Java 21 compatibility
37a1881 
Signed-off-by: Leonard Brünings <leonard.bruenings@gradle.com>
@leonard84 leonard84 requested a review from a team May 17, 2023 17:38
@leonard84 leonard84 self-assigned this May 17, 2023
erichaagdev
erichaagdev approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@erichaagdev erichaagdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was able to run tests with a Java 21 toolchain and test retries were successful.

https://ge.solutions-team.gradle.com/s/6fmbpggaculca/timeline?details=si6uhuz4tdufw&expanded=WyIxNiJd

@leonard84 leonard84 merged commit 735968f into main May 22, 2023
@leonard84 leonard84 deleted the leo/update-asm-9.5 branch May 22, 2023 08:49
@marcphilipp marcphilipp added this to the 1.5.3 milestone May 24, 2023
@hopper-signifyd hopper-signifyd mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshevche pshevche pshevche approved these changes

@snoopcheri snoopcheri snoopcheri approved these changes

@erichaagdev erichaagdev erichaagdev approved these changes

@jonatan-ivanov jonatan-ivanov jonatan-ivanov approved these changes

@marcphilipp marcphilipp marcphilipp approved these changes

Assignees

@leonard84 leonard84

Labels
None yet
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
6 participants
@leonard84 @marcphilipp @jonatan-ivanov @erichaagdev @snoopcheri @pshevche